All: delete outdated deprecations#17349
Merged
Merged
Conversation
erik-krogh
force-pushed
the
del-deps-sep-2024
branch
3 times, most recently
from
daa7060 to
46f09d0
Compare
erik-krogh
force-pushed
the
del-deps-sep-2024
branch
from
46f09d0 to
e76dcf9
Compare
|
This will bump the major version of all affected library packs. Any customer pack that depends on, say, There's nothing wrong with this per se. Just be aware of the customer impact when you make these sorts of changes. Batching these up into a single breaking change is good, and you seem to have done that here. |
tausbn
requested changes
Sep 4, 2024
Co-authored-by: Taus <tausbn@github.com>
erik-krogh
dismissed stale reviews from aschackmull, hvitved, michaelnebel, owen-mc, and jketema
via
49aaf65
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
tausbn
approved these changes
Sep 4, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Similar to last time: #16330
A little more than last time, so also a slightly larger change-note (now marked as breaking).
The swift CI failure is unrelated.